Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include convenience bash script for running rabbit mq locally #668

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Relm-Arrowny
Copy link

fix #615

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.56%. Comparing base (ac0fee8) to head (cf25570).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #668   +/-   ##
=======================================
  Coverage   92.56%   92.56%           
=======================================
  Files          35       35           
  Lines        1654     1654           
=======================================
  Hits         1531     1531           
  Misses        123      123           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks! Just a few small changes.

src/script/stomp_config.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should: If possible, I would like to use an image from dockerhub rather than build our own. Do we know of any that give us what we want (STOMP plugin etc.)?

Paging @DiamondJoseph

docs/tutorials/quickstart.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include convenience bash script for running RabbitMQ locally
2 participants