-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include convenience bash script for running rabbit mq locally #668
base: main
Are you sure you want to change the base?
Include convenience bash script for running rabbit mq locally #668
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 35 35
Lines 1654 1654
=======================================
Hits 1531 1531
Misses 123 123 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, thanks! Just a few small changes.
src/script/rabbitmq_setup/Dockerfile
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should: If possible, I would like to use an image from dockerhub rather than build our own. Do we know of any that give us what we want (STOMP plugin etc.)?
Paging @DiamondJoseph
…script-for-running-RabbitMQ-locally
fix #615