Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates #406

Closed
wants to merge 1 commit into from
Closed

Add issue templates #406

wants to merge 1 commit into from

Conversation

DiamondJoseph
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.52%. Comparing base (fb6fd0c) to head (bfc765b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   89.52%   89.52%           
=======================================
  Files          43       43           
  Lines        1805     1805           
=======================================
  Hits         1616     1616           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joeshannon
Copy link
Contributor

Did you mention that this was based on templates from another project?

Minor point but possibly the snake case and camel case should be consistent for the file names, or is that a GitHub thing?

@joeshannon
Copy link
Contributor

To be explicit I was referring to bug-report.md vs feature_request.md.

@DiamondJoseph
Copy link
Collaborator Author

To be explicit I was referring to bug-report.md vs feature_request.md.

I thought I'd just clicked the default buttons and only changed the content, but just tried again and they were both snake_case, not a mix of snake and kebab. I'll rename the file.

@DiamondJoseph
Copy link
Collaborator Author

Did you mention that this was based on templates from another project?

Largely based on the dodal template

Copy link
Collaborator

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the separation of bug report and feature request but I would favour more minimal templates, like dodal's

@callumforrester
Copy link
Collaborator

Alternatively: DiamondLightSource/python-copier-template#160

@DiamondJoseph
Copy link
Collaborator Author

Closing in favour of propagating up from DiamondLightSource/python-copier-template#160

@DiamondJoseph DiamondJoseph deleted the issue-templates branch September 5, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants