remove RunPlan class that wraps Task #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 88.93% 88.91% -0.02%
==========================================
Files 43 43
Lines 1798 1796 -2
==========================================
- Hits 1599 1597 -2
Misses 199 199 ☔ View full report in Codecov by Sentry. |
docs/user/reference/openapi.yaml
Outdated
There was a problem hiding this comment.
How did you generate this file? It'd be good to remove all the unrelated formatting only changes.
There was a problem hiding this comment.
I think I just ran ruff / pre-commit automatically
There was a problem hiding this comment.
now I auto-generated a new one using
python -m blueapi.cli schema -u.
formatting indeed has changed
DiamondJoseph
approved these changes
Mar 7, 2024
ZohebShaikh
pushed a commit
that referenced
this pull request
May 7, 2024
quick renaming 36 refs and delete the class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick renaming 36 refs and delete the class