Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example code to be correct #277

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Update example code to be correct #277

merged 1 commit into from
Jul 24, 2023

Conversation

DominicOram
Copy link
Contributor

To test:

  • Import the code into an IDE and confirm it has correct imports etc.

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #277 (eca21f2) into main (14d1bc0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          41       41           
  Lines        1412     1412           
=======================================
  Hits         1263     1263           
  Misses        149      149           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DominicOram
Copy link
Contributor Author

Thanks @tpoliaw, what's your workflow here? Are you happy for me to squash and merge?

@tpoliaw
Copy link
Contributor

tpoliaw commented Jul 24, 2023

I think squash and merge is the only strategy enabled. Would be good to remove the To test:.. comment from the auto-generated message though.

@DominicOram DominicOram merged commit 7b40ab5 into main Jul 24, 2023
23 checks passed
@DominicOram DominicOram deleted the DominicOram-patch-1 branch July 24, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants