Pin known compatible versions of dependencies #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DiamondJoseph
commented
Jul 7, 2023
•
DiamondJoseph
commented
- Pins Pydantic to 1.10 and Closes Pin pydantic to v1 #270
- Dodal and our pinned version of typing_extensions both conflict with Pydantic 2.0
- Pins FastAPI to 0.99: supports OpenAPI 3.1 while using Pydantic 1.0
- Pin Bluesky to 1.10 prior to AreaDetector staging change
- Pin ScanSpec to version compatible with Pydantic and FastAPI
- Pin Click to version compatible with mypy type checking
DiamondJoseph
force-pushed
the
pinnedPydantic
branch
from
ea763d9
to
b22af94
Compare
- Closes #270 - Dodal and our pinned version of typing_extensions both conflict with Pydantic 2.0 - Pins FastAPI to 0.99: supports OpenAPI 3.1 while using Pydantic 1.0 - Pin Bluesky to 1.10 prior to AreaDetector staging change - Pin ScanSpec to version compatible with Pydantic and FastAPI - Pin Click to version compatible with mypy type checking
DiamondJoseph
force-pushed
the
pinnedPydantic
branch
from
f6a4c8c
to
bf1dd37
Compare
Codecov Report
@@ Coverage Diff @@
## main #275 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 41 41
Lines 1412 1412
=======================================
Hits 1263 1263
Misses 149 149 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| "ophyd", | ||
| "nslsii", | ||
| "pyepics", | ||
| "pydantic", | ||
| "pydantic<2.0", |
There was a problem hiding this comment.
Should we not allow installing v2 and change all imports to v1?
There was a problem hiding this comment.
Let me see how it behaves with various versions of FastAPI
callumforrester
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.