Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obselete correlation_id handling from code #661

Open
keithralphs opened this issue Oct 10, 2024 · 0 comments
Open

Remove obselete correlation_id handling from code #661

keithralphs opened this issue Oct 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@keithralphs
Copy link
Contributor

Before tracing was added to the codebase, Callum had implemented a manually managed correlation_id which is passed round on the internal event system. This is no longer required as the trace_id from the Open Telemetry tracing implementation provides this identifier. The manual correlationId should therefore be removed from the code ensuring that, where necessary, propagation of the Trace context ensures that the record of the chain of events is maintained. The likely area for this is the propagation of event from the server to CLI via the message bus where the context should be transmitted via the stmp headers as is already implmentaed for Bluesky documents. The apporpiate functions from the observability-uttils library can be used for this purpose.

@callumforrester callumforrester added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants