Stomp Tests Timeout Forever

[callumforrester]

If I run the stomp tests without a valid message bus running, they should fail within the 10 second timeout (they usually fail earlier when disconnection occurs). They currently hang forever, this behaviour seems to have been present since #345 so probably has something to do with the fact that we are now logging exceptions rather than raising them. This would be unfortunate as it means our solution that made the CLI easier to use makes the tests harder to use.

This ticket is therefore to come up with a solution to #220 that also works for this.

[stan-dot]

this annoyed me just today. one time too many. will fix

[stan-dot]

got some work for this by mistake into #441

[stan-dot]

should we have some pytest.mark to NOT run those tests at all in the CI unit test setup? @callumforrester

[callumforrester]

They should always run in CI, and I haven't seen any problems with them in CI, have you?

I see the problem when running locally. We already have a pytest.mark to make them opt-out. We could change it to make them opt-in? Or, like dodal does, include the opt-out in the tox command

[stan-dot]

nevermind, I missed that mark at first.

[stan-dot]

todo: should add here in a new PR changes that were explored in #364 PR

[stan-dot]

one possible course of action is to mock - change this in the tests: time.sleep(self._reconnect_policy.initial_delay) so that we don't need to wait

[stan-dot]

running pytest -m"stomp"

[stan-dot]

what I see is that the test fails but then the debugger keeps running

[stan-dot]

going with the debugginer the culprit is here

[stan-dot]

this stopped once I check for existing connection before disconnectiong

` def disconnect(self) -> None:
LOGGER.info("Disconnecting...")
if not self.is_connected(): # first new line
return # second new line
# We need to synchronise the disconnect on an event because the stomp Connection
# object doesn't do it for us
disconnected = Event()
self._listener.on_disconnected = disconnected.set
self._conn.disconnect()
disconnected.wait()
self._listener.on_disconnected = None

    `

[stan-dot]

solved with #491