From 59e56ee0abea0e13cd914fdecbacde3653422ca6 Mon Sep 17 00:00:00 2001 From: Keith Ralphs Date: Tue, 13 Feb 2024 11:23:27 +0000 Subject: [PATCH] Correct template and exporter selection --- helm/blueapi/templates/deployment.yaml | 2 +- src/blueapi/tracing/tracing_utils.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/helm/blueapi/templates/deployment.yaml b/helm/blueapi/templates/deployment.yaml index b60bb85a5..04b741dd8 100644 --- a/helm/blueapi/templates/deployment.yaml +++ b/helm/blueapi/templates/deployment.yaml @@ -75,7 +75,7 @@ spec: - name: OTEL_EXPORTER_OTLP_ENDPOINT value: "{{ .Values.jaeger.otlp.host }}:{{ .Values.jaeger.otlp.port }}" - name: OTEL_EXPORTER_OTLP_INSECURE - value: {{ .Values.jaeger.otlp.insecure }} + value: "{{ .Values.jaeger.otlp.insecure }}" - name: OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_REQUEST value: {{ .Values.jaeger.otlp.request.headers }} - name: OTEL_INSTRUMENTATION_HTTP_CAPTURE_HEADERS_SERVER_RESPONSE diff --git a/src/blueapi/tracing/tracing_utils.py b/src/blueapi/tracing/tracing_utils.py index a19b2cd02..e72fef8d3 100644 --- a/src/blueapi/tracing/tracing_utils.py +++ b/src/blueapi/tracing/tracing_utils.py @@ -35,7 +35,7 @@ def instrument_fastapi_app(app: FastAPI, name: str) -> None: generation.""" resource = Resource(attributes={"service.name": name}) provider = TracerProvider(resource=resource) - provider.add_span_processor(BatchSpanProcessor(ConsoleSpanExporter())) + provider.add_span_processor(BatchSpanProcessor(OTLPSpanExporter())) set_tracer_provider(provider) FastAPIInstrumentor().instrument_app(app) @@ -43,7 +43,7 @@ def instrument_fastapi_app(app: FastAPI, name: str) -> None: def set_console_exporter() -> None: resource = Resource(attributes={"service.name": "BlueAPI"}) provider = TracerProvider(resource=resource) - provider.add_span_processor(BatchSpanProcessor(OTLPSpanExporter())) + provider.add_span_processor(BatchSpanProcessor(ConsoleSpanExporter())) def get_tracer(name: str) -> Tracer: