Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1489: Update message when trying to queue containers in uploaded shipments #847

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1489
JIRA ticket: LIMS-1506

Summary:

If a shipment has been uploaded as a CSV (or created by GDA), it doesn't have a safety level. #827 disabled the ability to queue containers in such shipments, but the message is not helpful, as it says "Cannot queue containers in shipments". We should make the message clearer.

Also, as already editing this file, I added some text to remind users to add PDB and/or sequence information to their proteins.

Changes:

  • If adding/editing a container in a shipment with a null safety level, display a message advising users to set the shipment safety level
  • When a new container is created, remind users to add PDB and/or sequence information to their proteins

To test:

  • Go to a shipment with safety level 'green', eg /shipments/sid/59056
    • Click Add container, check the Queue For UDC checkbox is available
    • View an existing container, check the Queue button is displayed
  • Edit the shipment so that the safety level is red or yellow
    • Click Add container, check the Queue For UDC checkbox is not available
    • View an existing container, check the Queue button is not displayed
  • Go to a shipment with no safety level, eg /shipments/sid/58582
    • Click Add container, check the Queue For UDC checkbox is not available, with a message advising what needs to be done
    • View an existing container, check the Queue button is not displayed, with a message advising what needs to be done
  • Create a puck (in any shipment), check the notification reminds users to add sequences and/or PDBs.

@gfrn gfrn self-requested a review October 21, 2024 10:33
@gfrn gfrn self-assigned this Oct 21, 2024
@gfrn gfrn removed their assignment Oct 21, 2024
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R5.1 October 22, 2024 08:40
@ndg63276 ndg63276 merged commit 4b4ec37 into pre-release/2024-R5.1 Oct 22, 2024
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1489/cannot-queue-containers-in-csv-shipments branch October 22, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants