Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1463: Always display Mesh3D data collections as grid scans #845

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Oct 9, 2024

JIRA ticket: LIMS-1463

Summary:

When Hyperion adds a Mesh3D experiment to ISPyB, Synchweb initially displays it as a rotational data collection, only updating to a grid scan style after a refresh. We should detect that it is a grid scan immediately.

Changes:

  • Treat the experiment type Mesh3d (ie hyperion grid scans) the same as Mesh (ie GDA grid scans)
  • Force both to display as grid scans, irrespective of the axis range and number of images

To test:

  • View a stopped Hyperion grid scan (eg /dc/visit/cm37235-4/dcg/13099843) check it displays in the style of a grid scan, ie space for a diffraction image and space for a crystal snapshot, no space for a graph of spot counts
  • View a completed Hyperion grid scan (eg /dc/visit/cm37235-4/dcg/13087189), check it displays in the style of a grid scan (ie unchanged)
  • View a GDA grid scan (eg /dc/visit/cm37236-4/id/15488302), check it displays in the style of a grid scan (ie unchanged)
  • View a "SAD" data collection (eg /dc/visit/cm37236-4/id/15488314), check it is unchanged from production)
  • View a "Serial Fixed" (eg /dc/visit/cy37017-1/id/15324649) and "Serial Jet" (eg /dc/visit/cm37275-4/id/14945838) experiment, check they are unchanged from production

@NKatti2011 NKatti2011 self-requested a review October 14, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants