Handle -ve rotations, null overlap in sm/DC #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I19 is now doing small molecule serial, where every other collection is run with backwards oscillation. Unfortunately, recording this in the database doesn't show the autoprocessing sections in Synchweb. Change the check to be truthy (nonzero) instead of purely positive. Also change an adjacent issue where a null value for overlap was passing the intended non-zero check (null != 0).
ndg63276
reviewed
Feb 16, 2024
ndg63276
reviewed
Feb 16, 2024
ndg63276
requested changes
Feb 16, 2024
Co-authored-by: Mark W <[email protected]>
Co-authored-by: Mark W <[email protected]>
|
This appears to work fine! |
ndg63276
approved these changes
Feb 21, 2024
gfrn
pushed a commit
that referenced
this pull request
Feb 26, 2024
* Handle -ve rotations, null overlap in sm/DC I19 is now doing small molecule serial, where every other collection is run with backwards oscillation. Unfortunately, recording this in the database doesn't show the autoprocessing sections in Synchweb. Change the check to be truthy (nonzero) instead of purely positive. Also change an adjacent issue where a null value for overlap was passing the intended non-zero check (null != 0). * Update client/src/js/templates/types/sm/dc/dc.html Co-authored-by: Mark W <[email protected]> * Update client/src/js/templates/types/sm/dc/dc.html Co-authored-by: Mark W <[email protected]> --------- Co-authored-by: Mark W <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1232
Summary:
I19 is now doing small molecule serial, where every other collection is run with backwards oscillation. Unfortunately, recording this accurately in ISPyB doesn't show the autoprocessing sections in Synchweb.
This changes the check to be truthy (nonzero) instead of purely positive.
Also fixes an adjacent issue where a null value for overlap was passing the intended non-zero check (null != 0). This is made truthy also.
Changes:
To test: