Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1107: Fix MCA spectra display of certain elements #699

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1107

Summary:

K and L edges defined in the json file as "-" cause server errors. So an MCA spectrum that is supposed to show the Xe-L edge fails.

Changes:

  • Remove "-" as possible energies for Xe-L and Tc-L edges
  • Remove Np-K, Pu-K, Am-K edges entirely as they had only "-" values
  • Pretty print file with indenting and ordered keys to help in future debugging

To test:

  • View an MCA spectrum with Xe-L displayed eg /dc/visit/cm33903-5/ty/mca/id/14461
  • View an MCA spectrum without any of the above mentioned edges eg /dc/visit/cm33903-5/ty/mca/id/14569

Copy link
Contributor

@MattPrit MattPrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ndg63276 ndg63276 merged commit e01123f into prerelease Dec 4, 2023
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1107/Fix-MCA-spectra-display-of-certain-elements branch December 4, 2023 10:10
gfrn pushed a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants