Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1113: Shipping service dispatch redirect #698

Closed

Conversation

MattPrit
Copy link
Contributor

@MattPrit MattPrit commented Nov 28, 2023

JIRA ticket: LIMS-1113

Summary:
Adds the option to redirect to the shipping service to book shipments when requesting dispatch of appropriate Dewars.

Changes:

  • Adds feature flag $use_shipping_service_redirect which enables/disables this feature
  • On requesting Dewar dispatch, create a shipment request in the shipping service and redirect to the appropriate shipment workflow to book a shipment
  • Use minimised dispatch request email for shipments booked via the new pathway

To test:

  • Check that the appropriate dispatch form is displayed for academic, industrial, international users
  • Check that the appropriate shipment request is created in the shipping service when requesting dispatch of a domestic academic Dewar
  • Check that the minified dispatch-lite email template is used for such dispatch requests; ensure this has an appropriate link to where a Goods Handling operative can view and print the air waybill
  • Check that the dispatch button links to the shipping service once a dispatch shipment request has been successfully created.

api/src/Page/Shipment.php Outdated Show resolved Hide resolved
@MattPrit MattPrit marked this pull request as ready for review December 7, 2023 10:53
@MattPrit MattPrit marked this pull request as draft December 8, 2023 13:00
@MattPrit MattPrit marked this pull request as ready for review December 11, 2023 11:31
@MattPrit MattPrit requested a review from gfrn January 25, 2024 10:25
@MattPrit
Copy link
Contributor Author

MattPrit commented Jan 25, 2024

NOTE: Requires the addition of the externalShippingIdFromSynchrotron column to the Dewar table in ISPyB. Since _get_dewars in Shipment.php requires this column, the shipments table page, the shipment page, and possibly others will not work without this new column.

@MattPrit
Copy link
Contributor Author

NOTE: Requires the addition of the externalShippingIdFromSynchrotron column to the Dewar table in ISPyB. Since _get_dewars in Shipment.php requires this column, the shipments table page, the shipment page, and possibly others will not work without this new column.

This change has now been made, see DiamondLightSource/ispyb-database#228

@MattPrit MattPrit closed this Apr 30, 2024
@ndg63276 ndg63276 deleted the feature/lims-1113/shipping-service-dispatch-redirect branch September 4, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants