Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1126: Improve display of pia_estimated_d_min #695

Merged

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1126

Summary:

Following on from LIMS-140, improve the display of pia_estimated_d_min

Changes:

To test:

  • View a VMXi gridscan eg /dc/visit/nt37104-4/id/12141916, check pia_estimated_d_min shows red around the crystals
  • Check a weaker diffracting grid scan eg /dc/visit/nt37104-4/id/12097225, check pia_estimated_d_min shows more yellow around the crystals rather than red
  • Check other pia results are unaffected
  • Check non-VMXi grid scans are unaffected

@ndg63276 ndg63276 merged commit 1f07ec5 into prerelease Feb 9, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1126/improve-pia-estimated-d-min branch February 9, 2024 11:46
gfrn pushed a commit that referenced this pull request Feb 26, 2024
* LIMS-1126: Improve display of pia_estimated_d_min

* LIMS-1126: Improve display of pia_estimated_d_min

---------

Co-authored-by: Mark Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants