On Build: Satisfy Psalm Config (#689) #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move globals in OIDC and tidy, remove static ref in Download, conform to php7 in processing * implement strpos properly --------- Co-authored-by: John Holt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move globals in OIDC and tidy, remove static ref in Download, conform to php7 in processing
implement strpos properly
NOTE: (PR title should be of the form ticket:short description, e.g. TICKET-123: Add more templates)
JIRA ticket: TICKET-123
Summary:
A brief description of what this pull request aims to achieve
Changes:
To test: