Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Build: Satisfy Psalm Config #689

Merged
merged 2 commits into from
Nov 2, 2023
Merged

On Build: Satisfy Psalm Config #689

merged 2 commits into from
Nov 2, 2023

Conversation

John-Holt-Tessella
Copy link
Contributor

JIRA ticket: none

Summary:

Make prerelease pass Psalm in build

Changes:

  • Move globals in OIDC and use lazy loaf pattern for config
  • Remove static ref in Download
  • Conform to o php7 in processing

To test:

  • Log in
  • Download something from data collection (archive)
  • View something from a data collection
  • Look at an image in downstream processing

@John-Holt-Tessella John-Holt-Tessella merged commit 4b7047c into prerelease Nov 2, 2023
2 checks passed
@John-Holt-Tessella John-Holt-Tessella deleted the fix/psalm_errors branch November 2, 2023 16:50
John-Holt-Tessella added a commit that referenced this pull request Nov 2, 2023
@John-Holt-Tessella
Merge pull request #690 from DiamondLightSource/prerelease
6a64ee7 
On Build: Satisfy Psalm Config (#689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@John-Holt-Tessella @gfrn