Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-309: Remove the Create New button in the protein acronym field for MX #685

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-309

Summary:

MX users shouldn't be able to create new proteins within ISPyB, they should create them in UAS to be assessed, then they are copied over. The 'Create New' button that appears now doesn't do anything, so should be removed (for MX proteins, not in general)

Changes:

  • Set property canCreateNewItem to false when creating the combo box

To test:

  • Create a new puck, try to create a new protein, verify the 'Create New' button doesn't appear.
  • Check can use existing proteins

Copy link
Contributor

@MattPrit MattPrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ndg63276 ndg63276 merged commit 6f36e9f into prerelease Nov 2, 2023
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-309/remove-create-new-protein-button-for-mx branch November 2, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants