Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1074: Allow accessing zipped files #684

Merged

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1074

Summary:

To save on disk space, many files created by auto processing pipelines have been zipped (*.gz), which breaks the links to them in Synchweb, as well as a number of image files and map / model viewers. These should be fixed server-side.

Changes:

  • Use gzopen and gzread to temporarily unzip the processing files before serving them to the front end
  • Add already zipped files to archive.zip file served by "Archive" button (they download as unzipped files zipped together)
  • Fix the map / model viewer shell script to unzip the relevant files first
  • Fix 2 silly spelling mistakes

To test:

  • View a pre-2022 data collection with autoprocessing, eg /dc/visit/mx23694-64/id/6669874
  • For fast_dp
    • Check the 'Archive' button downloads a full zip file
    • Check the 'Plots' button produces graphs
    • Check the 'Radiation Damage' button produces a graph
    • View the 'Logs & Files' modal, and try viewing files of type log and graph and downloading files of type log, graph and result
    • Repeat tests for different autoprocessing pipelines
  • For downstream processing
    • Check the 'Archive' and 'Logs & Files' buttons as above
    • Check the 'Map / Model Viewer' button loads a model
    • Check thumbnails of models load for Autosharp, Autobuild and Crank2
  • Check no error messages appear on display or in dev console

Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how urgent these thing are. I will go test ome stuff :-)

api/scripts/mtz2map.sh Show resolved Hide resolved
api/scripts/mtz2map.sh Show resolved Hide resolved
api/scripts/mtz2map.sh Show resolved Hide resolved
api/scripts/mtz2map.sh Show resolved Hide resolved
api/src/Downstream/Type/FastEp.php Outdated Show resolved Hide resolved
api/src/Page/Download.php Show resolved Hide resolved
api/src/Page/Download.php Outdated Show resolved Hide resolved
Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files in archives (once downloaded) appear to be files but are actually the zipped version of those files.
In downstream processing click Archive

@John-Holt-Tessella John-Holt-Tessella merged commit 9a0ad6f into prerelease Nov 2, 2023
2 checks passed
@John-Holt-Tessella John-Holt-Tessella deleted the fix/LIMS-1074/allow-accessing-zipped-files branch November 2, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants