Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-1068: Move discovery away from constructor, get cookie expiry dynamically #683

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

gfrn
Copy link
Collaborator

@gfrn gfrn commented Oct 20, 2023

JIRA ticket: LIMS-1068

Summary:

  • Reduce number of calls to OIDC provider by only performing discovery when necessary
  • Get expiration time for token from provider, apply it to cookie

Changes:

  • Cookie expiry is applied based on value returned from OIDC provider
  • Endpoint discovery is only performed when a function is called and there are no known endpoints

To test:

  • Check if user logout behaves as expected
  • Check if user login behaves as expected
  • Check if opening page in a new tab doesn't trigger login
  • Check if moving between pages works

@gfrn gfrn added improvement php Pull requests that update PHP code labels Oct 20, 2023
@gfrn gfrn self-assigned this Oct 20, 2023
@ndg63276 ndg63276 self-requested a review November 1, 2023 10:41
@ndg63276 ndg63276 self-requested a review November 2, 2023 10:04
Copy link
Collaborator

@ndg63276 ndg63276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfrn gfrn changed the base branch from master to prerelease November 2, 2023 10:47
@gfrn gfrn merged commit e0ac33d into prerelease Nov 2, 2023
2 checks passed
@gfrn gfrn deleted the fix/lims-1068/oidc-discovery-endpoint-fix branch April 2, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement php Pull requests that update PHP code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants