Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1029: Fix bug creating lab contact with login #676

Merged
merged 1 commit into from
Oct 4, 2023
Merged

LIMS-1029: Fix bug creating lab contact with login #676

merged 1 commit into from
Oct 4, 2023

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Sep 26, 2023 •
edited
Loading

JIRA ticket: LIMS-1029

Summary:

Fix bug getting laboratoryId when creating a Lab Contact using the Login field, introduced in #622

Changes:

  • Fix getting laboratoryId, as db queries always return a list

To test:

  • Test creating a Lab Contact using the Login field, when logged in someone with an associated Laboratory eg ndg63276
  • Test creating a Lab Contact using the Login field, when logged in as someone with no associated Laboratory
  • Test creating a Lab Contact leaving the Login field blank

@ndg63276 ndg63276 changed the base branch from pre-release/2023-R4.2 to prerelease October 2, 2023 12:08
@John-Holt-Tessella John-Holt-Tessella merged commit bd36cd4 into prerelease Oct 4, 2023
2 checks passed
@John-Holt-Tessella John-Holt-Tessella deleted the fix/LIMS-1029/lab-contact-creation-fails branch October 4, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Holt-Tessella John-Holt-Tessella John-Holt-Tessella approved these changes

@NKatti2011 NKatti2011 Awaiting requested review from NKatti2011

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @John-Holt-Tessella