Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-902: Clear sessionId from containers when requesting a dewar transfer #673

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-902

Summary:

When a user requests a dewar transfer, they either specify a future visit, or they can leave it blank if the visit has not yet been created. But if the samples have been collected through UDC, the containers will have an associated visit, and so the dewar won't appear on the list of those that need visits. So if they are requesting a transfer to a not-yet-created visit, then we should clear the sessionid's from the containers.

Changes:

  • Get list of containers within the dewar
  • Don't overwrite $dew so they can be accessed
  • If the session id is null, set each container's session id to be null

To test:

  • Test a dewar transfer request on a dewar with UDC pucks to a null session, puck session ids should be set to null
  • Test a dewar transfer request on a dewar with UDC pucks to a non-null session, puck session ids should be unaffected
  • Test a dewar transfer request on an empty dewar to a null session
  • Test a dewar transfer request on an empty dewar to a non-null session

@ndg63276 ndg63276 changed the base branch from prerelease to master June 24, 2024 09:36
@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R3.2 July 9, 2024 11:57
@ndg63276 ndg63276 merged commit f95dc81 into pre-release/2024-R3.2 Jul 9, 2024
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-902/clear-sessionid-from-containers-when-requesting-dewar-transfer branch July 9, 2024 12:01
ndg63276 added a commit that referenced this pull request Jul 23, 2024
* LIMS-1319: Show dose for all data collection types (#791)

* LIMS-954: Add ability to edit manufacturer serial no on dewars (#652)

* LIMS-1276: Add printed date to shipping labels (#755)

* LIMS-902: Clear sessionId from containers when requesting a dewar transfer (#673)

* LIMS-277: Fix sample changer view scaling (#794)

* LIMS-121: Allow use of VMXm Gridboxes and Cartridges (#732)

* LIMS-1257: Allow population of source fields (#769)

* LIMS-1382: Add message to users about using the shipping service (#801)

---------

Co-authored-by: Mark Williams <[email protected]>
Co-authored-by: Guilherme Francisco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants