Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-150: Cannot edit fault components #670

Merged
merged 1 commit into from
Sep 25, 2023
Merged

LIMS-150: Cannot edit fault components #670

merged 1 commit into from
Sep 25, 2023

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-150

Summary:

Fix bug where https://ispyb.diamond.ac.uk/faults/edit is broken.

Changes:

  • Add MarionetteView component in the same way as faults/add and faults/{faultid}

To test:

  • Test user with fault_admin privilege can see the "Fault Database Editor" at faults/edit
  • Test unprivileged user sees an error
  • Test can add new Systems, Components and Subcomponents

@John-Holt-Tessella John-Holt-Tessella merged commit be3e0cc into prerelease Sep 25, 2023
2 checks passed
@John-Holt-Tessella John-Holt-Tessella deleted the fix/LIMS-150/cannot-edit-fault-components branch September 25, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Holt-Tessella John-Holt-Tessella John-Holt-Tessella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @John-Holt-Tessella