New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-996: Trim empty space around courier name #664

Merged

ndg63276 merged 1 commit into prerelease from fix/LIMS-996/trim-empty-space-around-courier-name

Nov 16, 2023

Collaborator

ndg63276 commented Sep 14, 2023

Ticket: LIMS-996

Changes:

Trim courier name before comparing to 'dhl', otherwise couriers like ' dhl' and 'dhl ' will be rejected.

Tests:

Go to a test shipment eg on mx23694, edit courier name to 'DHL', check 'Create Air Waybill' button remains after refresh
Edit courier name to ' DHL', check button remains after refresh
Edit courier name to 'Fedex', check button has gone after refresh


          LIMS-996: Trim empty space around courier name

3f07d6e

ndg63276 requested a review from MattPrit

September 14, 2023 14:19

gfrn approved these changes

View reviewed changes

ndg63276 merged commit f15e57a into prerelease

2 checks passed

ndg63276 deleted the fix/LIMS-996/trim-empty-space-around-courier-name branch

November 16, 2023 09:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet