Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-903: Update email on dewar transfer #649

Merged
merged 3 commits into from
Aug 23, 2023
Merged

LIMS-903: Update email on dewar transfer #649

merged 3 commits into from
Aug 23, 2023

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-903

Summary:

Update the email sent to LCs when an internal dewar transfer is requested.

Changes:

  • Remove instructions to physically move dewar, this is not required
  • Remove instructions to EHCs as they are not involved in the process any more
  • Move row with new LC details
  • Remove references to Diamond-specifically

To test:

  • Test email still sent with all dewar details

@ndg63276 ndg63276 requested a review from MattPrit August 23, 2023 13:53
MattPrit
MattPrit approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@MattPrit MattPrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ndg63276 ndg63276 merged commit cbb03d3 into prerelease Aug 23, 2023
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-903/update-email-on-dewar-transfer branch August 23, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattPrit MattPrit MattPrit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @MattPrit