New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-899: Null path to blobs causes errors #632

Merged

ndg63276 merged 1 commit into prerelease from fix/LIMS-899/null-blob-filename-causes-errors

Jul 20, 2023

Collaborator

ndg63276 commented Jul 18, 2023

Ticket: LIMS-899

The code tries to extract the mime type of an image blob from the file extension
If filepath (or view1/2/3) is null in MXMRRunBlob, that fails with Undefined Variable

Testing:

Go to a data collection with downstream processing eg https://ispyb.diamond.ac.uk/dc/visit/cm33903-3/id/11034210
Click on downstream processing bar to expand
See failed requests to eg https://ispyb.diamond.ac.uk/api/processing/downstream/images/96310113?prop=cm33903


          LIMS-899: Null path to blobs causes errors

c46aac3

ndg63276 requested a review from MattPrit

July 18, 2023 09:39

MattPrit approved these changes

View reviewed changes

Contributor

MattPrit left a comment

Looks good to me

ndg63276 merged commit 211a08c into prerelease

2 checks passed

ndg63276 deleted the fix/LIMS-899/null-blob-filename-causes-errors branch

July 20, 2023 15:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet