New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-871: Fix wrong number of dewar uses for staff #626

Merged

ndg63276 merged 1 commit into prerelease from fix/LIMS-871/fix-wrong-number-of-dewar-uses

Jul 14, 2023

Collaborator

ndg63276 commented Jul 11, 2023

Ticket: LIMS-871

Staff see wrong number of uses of each dewar on the Registered Dewars page, they see (actual number of uses) * (number of proposals the dewar belongs to)
Staff also get redirected to the max(proposal) when clicking on a registered dewar, and then only see the shipments for that dewar on that proposal

Testing:

Log in as a staff member, go to proposal mx29907.
Go to Registered Dewars page
Search for DLS-MX-0873, it should show "# Uses" as around 19 (not 57)
Click on DLS-MX-0873, proposal should stay as mx29907 (not switch to mx30951)
The shipments section should show all 19 uses of this dewar, even those that belong to other proposals
Repeat as a user from mx29907, the only difference should be in step 5, it should only show shipments from mx29907


          LIMS-871: Fix wrong number of dewar uses for staff

4ffceb2

ndg63276 requested a review from MattPrit

July 11, 2023 15:34

MattPrit approved these changes

View reviewed changes

Contributor

MattPrit left a comment

Looks good to me

ndg63276 merged commit fcfbe4c into prerelease

2 checks passed

ndg63276 deleted the fix/LIMS-871/fix-wrong-number-of-dewar-uses branch

July 14, 2023 11:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet