Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-95: Show max score for each drop in a plate #621

Merged
merged 3 commits into from
Oct 16, 2023
Merged

LIMS-95: Show max score for each drop in a plate #621

merged 3 commits into from
Oct 16, 2023

Conversation

ndg63276
Copy link
Collaborator

@ndg63276 ndg63276 commented Jul 6, 2023 •
edited by John-Holt-Tessella
Loading

Ticket: LIMS-95

  • Once a plate is imaged, the previous drop scoring is hidden, so a user may have to click through each drop again and score them
  • Add a checkbox to show the 'max' score for each drop, which will allow them to quickly see which drops have been highly scored in the past

Testing (on dev db):

  • go to proposal 30330, go to a container
  • click on some drops, set a score, change inspections and repeat
  • tick 'Max scores' radio button to show the highest score colour for each drop
  • Also try "Current scores", "Data Status" and "Auto Scores" with various drop downs (Schema CHIMP should not be visible)

@ndg63276
Copy link
Collaborator Author

LGTM.

John-Holt-Tessella
John-Holt-Tessella approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backend part is good. @ndg63276 has reviewed the part I did and is happy

@John-Holt-Tessella John-Holt-Tessella merged commit fc4295e into prerelease Oct 16, 2023
2 checks passed
@John-Holt-Tessella John-Holt-Tessella deleted the improvement/LIMS-95/show-max-score-for-each-drop branch October 16, 2023 12:20
@ndg63276 ndg63276 mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Holt-Tessella John-Holt-Tessella John-Holt-Tessella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @John-Holt-Tessella