LIMS-59: Never write null to DewarTransportHistory.storageLocation #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John-Holt-Tessella
suggested changes
Sep 1, 2023
There was a problem hiding this comment.
I think there are several other places that this value could be null. Would it be wise to add a single function for adding dewar history? Maybe by using the updateDewarHistory funtion in assign data? Although it is a bit of a weird name for it. Feels like it would be better in a dewarData function?
| @@ -3090,7 +3090,7 @@ function _cancel_pickup() | |||
| $this->_error('No such lab contact'); | |||
| $cont = $cont[0]; | |||
|
|
|||
| $dewars = $this->db->pq("SELECT d.dewarid | |||
| $dewars = $this->db->pq("SELECT d.dewarid, d.storagelocation | |||
There was a problem hiding this comment.
could the dewar storage location not be null?
There was a problem hiding this comment.
I've added a check for null on line 3116
|
Refactoring into a single function is probably a good idea, but maybe that should be a new ticket. Hopefully have resolved the issues with any insert into DTH statements. |
John-Holt-Tessella
approved these changes
Oct 12, 2023
John-Holt-Tessella
suggested changes
Oct 12, 2023
Tests now pass :) |
added 3 commits
October 12, 2023 13:17
…ttps://github.com/DiamondLightSource/SynchWeb into fix/LIMS-59/never-write-null-to-DTH-storageLocation
John-Holt-Tessella
approved these changes
Oct 12, 2023
John-Holt-Tessella
deleted the
fix/LIMS-59/never-write-null-to-DTH-storageLocation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: LIMS-59