Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-452: Speed up _get_all_containers #559

Merged
merged 4 commits into from
Aug 16, 2023
Merged

LIMS-452: Speed up _get_all_containers #559

merged 4 commits into from
Aug 16, 2023

Conversation

ndg63276
Copy link
Collaborator

Ticket: LIMS-452

Speed up the request to _get_all_containers, by:

  • moving various joins into subqueries (blsubsample is the biggest gain)
  • only joining to Crystal and Protein if needed

John-Holt-Tessella
John-Holt-Tessella previously requested changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@John-Holt-Tessella John-Holt-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update total too (join does not work). Try clicking "has sub sample" on container page

api/src/Page/Shipment.php Outdated Show resolved Hide resolved
@ndg63276 ndg63276 dismissed John-Holt-Tessella’s stale review August 16, 2023 10:14

Hopefully fixed in latest commit

@John-Holt-Tessella John-Holt-Tessella merged commit c53a41f into prerelease Aug 16, 2023
2 checks passed
@John-Holt-Tessella John-Holt-Tessella deleted the improvement/LIMS-452/speed-up-get-all-containers branch August 16, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-Holt-Tessella John-Holt-Tessella John-Holt-Tessella approved these changes

@KarlLevik KarlLevik Awaiting requested review from KarlLevik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndg63276 @John-Holt-Tessella