Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would it be possible to remove client/src/js/config.json ? #379

Closed
dsclassen opened this issue Dec 7, 2022 · 4 comments · Fixed by #705
Closed

Would it be possible to remove client/src/js/config.json ? #379

dsclassen opened this issue Dec 7, 2022 · 4 comments · Fixed by #705

Comments

@dsclassen
Copy link

dsclassen commented Dec 7, 2022

I use Ansible to deploy SynchWeb to our server and I make changes to client/src/js/config.json during the process. Since this file is tracked in git, this causes all subsequent Ansible tasks to fail.

The client/src/js/config_sample.json file is still there for people to have a reference to start from, but maybe we could remove the DLS-specific client/src/js/config.json version?

This would follow the pattern in api directory where there is no api/config.php. One is expected to make a copy of api/config_sample.php and customize it to your site.

I can always use "force" during the git checkout step so this isn't a huge deal.

@John-Holt-Tessella
Copy link
Contributor

I don't see why not, but I am not sure I am significantly empowered to do this. I will talk with the team and then we will get it prioritised. Presumably this is not a new thing, but is there a timescale you need this fixing on?

@dsclassen
Copy link
Author

I doubt this is of very high priority, and I guess I could just make a small PR myself to deal with it.

@John-Holt-Tessella
Copy link
Contributor

That would be cool, we can then approve it.

@ndg63276
Copy link
Collaborator

Added as an internal issue at https://jira.diamond.ac.uk/browse/LIMS-694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants