Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made notifications for a silent punishment #624

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

tWizT3ddreaMr
Copy link
Contributor

The silent notification perm is the same as notify but silentnotify, seems like it should be that, but I was not sure how you would want to structure the perm

so permission for silent mute is ab.silentnotify.mute

This is for feature request #557
Resubmitted for the developement branch since it wasn't letting me change base

The silent notification perm is the same as notify but silentnotify, seems like it should be that

so permission for silent mute is ab.silentnotify.mute
@Hopefuls
Copy link
Collaborator

Hopefuls commented Jul 3, 2023

Is it possible to have this be unified with the current permissions?

Such as:
ab.silentnotify.tempban -> ab.notify.tempban.silent

@tWizT3ddreaMr
Copy link
Contributor Author

It sure is, however I did it this way so if one were to give ab.notifify.* that wouldn't include these for ease of use and to avoid any unseen issues.
However I am not attached to the permission being separate as most people getting one will get the other on my server.

@DevLeoko
Copy link
Owner

DevLeoko commented Jul 4, 2023

I actually think that ab.silentnotify.* aligns pretty well with our current permission layout, given that we also have ab.undoNotify.*.
Also, I think it is good that ab.notify.* does not include the silent notify permissions.

So if you don't have any objections @Hopefuls I'd approve and merge

@Hopefuls
Copy link
Collaborator

Hopefuls commented Jul 4, 2023

Yup looks good to me

Copy link
Owner

@DevLeoko DevLeoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution to advancedban

@DevLeoko DevLeoko merged commit 7d839b4 into DevLeoko:development Jul 4, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants