Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect backtraces for segfaults and whatnot #58

Merged
merged 7 commits into from
Aug 26, 2024
Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Aug 23, 2024

Description

Note the default GitHub Actions runner for Linux uses apport, which doesn't make it easy to get crash dumps / back traces. The macOS codepath works perfectly, and the systemd flow works correctly if the host has systemd-coredump installed. If it doesn't, no error is raised.

Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

Copy link

netlify bot commented Aug 23, 2024

Deploy Preview for detsys-ts-docs ready!

Name Link
🔨 Latest commit c9c4c80
🔍 Latest deploy log https://app.netlify.com/sites/detsys-ts-docs/deploys/66cc7caceff9ab000878b167
😎 Deploy Preview https://deploy-preview-58--detsys-ts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@grahamc grahamc marked this pull request as draft August 24, 2024 01:18
@grahamc grahamc marked this pull request as ready for review August 24, 2024 01:58
Copy link
Member

@lucperkins lucperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits

src/backtrace.ts Outdated Show resolved Hide resolved
src/backtrace.ts Show resolved Hide resolved
src/backtrace.ts Outdated Show resolved Hide resolved
src/backtrace.ts Outdated Show resolved Hide resolved
src/backtrace.ts Outdated Show resolved Hide resolved
@grahamc grahamc merged commit cf1897a into main Aug 26, 2024
5 checks passed
@grahamc grahamc deleted the collect-crash-logs branch August 26, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants