Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate #2 and other improvements #4

Merged
merged 18 commits into from
Apr 10, 2024
Merged

Incorporate #2 and other improvements #4

merged 18 commits into from
Apr 10, 2024

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Apr 7, 2024

description

Improvements from integrating all the pieces together.

Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

grahamc and others added 18 commits April 5, 2024 20:59
lucperkins
lucperkins requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@lucperkins lucperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit, otherwise LGTM

.github/workflows/ci.yml Show resolved Hide resolved
@lucperkins lucperkins mentioned this pull request Apr 10, 2024
Closed
@lucperkins lucperkins merged commit 146bcfa into main Apr 10, 2024
1 check passed
@lucperkins lucperkins deleted the improvements-plus-pr2 branch April 10, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucperkins lucperkins lucperkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @lucperkins