You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
Also, there should probably be some better error handling -- would be nice if there was some way to differentiate between fatal and not-so-fatal errors.
If we have a lot of potentially-non-fatal errors, maybe we could change return signatures to be Result<(), Vec<Error>>, and report all non-fatal errors at the end?
The text was updated successfully, but these errors were encountered:
This return type is a bit weird. It might be worth looking out for ways to improve this, like an enum of DetectionResult { ExecError, ParseError, Ok } -- but not sure, and definitely not asking you to do it now.
Also, there should probably be some better error handling -- would be nice if there was some way to differentiate between fatal and not-so-fatal errors.
Originally posted by @cole-h in #1 (comment)
If we have a lot of potentially-non-fatal errors, maybe we could change return signatures to be
Result<(), Vec<Error>>
, and report all non-fatal errors at the end?The text was updated successfully, but these errors were encountered: