Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

No more unwraps or expects #5

Open
cole-h opened this issue Aug 17, 2021 · 1 comment
Open

No more unwraps or expects #5

cole-h opened this issue Aug 17, 2021 · 1 comment

Comments

@cole-h
Copy link
Member

cole-h commented Aug 17, 2021

Also, there should probably be some better error handling -- would be nice if there was some way to differentiate between fatal and not-so-fatal errors.

Originally posted by @cole-h in #1 (comment)


If we have a lot of potentially-non-fatal errors, maybe we could change return signatures to be Result<(), Vec<Error>>, and report all non-fatal errors at the end?

@cole-h
Copy link
Member Author

cole-h commented Aug 18, 2021

Another place to check:

This return type is a bit weird. It might be worth looking out for ways to improve this, like an enum of DetectionResult { ExecError, ParseError, Ok } -- but not sure, and definitely not asking you to do it now.

Originally posted by @grahamc in #1 (comment)

@cole-h cole-h changed the title Improve error handling No more unwraps or expects Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant