Fix redundant ConfigProperty queries in BadgeResource

[nscuro]

Description

Fixes redundant ConfigProperty queries in BadgeResource.

If unauthenticated badge access is enabled, the same ConfigProperty was previously queried three times. Since badges are embedded in public places, it'd be beneficial if the respective resources avoided unnecessary work.

Addressed Issue

N/A

Additional Details

N/A

Checklist

• I have read and understand the contributing guidelines
• This PR fixes a defect, and I have provided tests to verify that the fix is effective
• This PR implements an enhancement, and I have provided tests to verify that it works as intended
• This PR introduces changes to the database model, and I have added corresponding update logic
• This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 56d9deb1	✅ 100.00% (target: 70.00%)

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (56d9deb)	Report Missing	Report Missing	Report Missing
Head commit (c85bf47)	22437	17744	79.08%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#4202)	16	16	100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[SaberStrat]

Oops, sorry. Didn’t think about that when I put those multiplemethod calls in the ifs. 😬

[nscuro]

No worries at all, I also missed it during the review.