Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notification For BOM_VALIDATION_FAILED #3796

Conversation

aravindparappil46
Copy link
Contributor

Description

If uploaded BOM is invalid, dispatches a notification with InvalidBomProblemDetails before throwing the respective exception

Addressed Issue

Fixes #3778 (Dependent on frontend PR)

Additional Details

In the existing BomResource.validate() method, added functionality to dispatch a Notification for BOM_VALIDATION_FAILED

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

If uploaded BOM is invalid, dispatches a notification with InvalidBomProblemDetails before
throwing the respective exception

Signed-off-by: Aravind Parappil <[email protected]>
Signed-off-by: Aravind Parappil <[email protected]>
Copy link

codacy-production bot commented Jun 2, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% (target: -1.00%) 93.33% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (133e5ba) 21667 16437 75.86%
Head commit (451aaa6) 21708 (+41) 16478 (+41) 75.91% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3796) 45 42 93.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@nscuro nscuro added this to the 4.12 milestone Jun 2, 2024
@nscuro nscuro added the enhancement New feature or request label Jun 2, 2024
Instead of adding the whole problemDetails object, just storing the errors now

Signed-off-by: Aravind Parappil <[email protected]>
Signed-off-by: Aravind Parappil <[email protected]>
Signed-off-by: Aravind Parappil <[email protected]>
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

On a related note, any thoughts on #3795?

@nscuro nscuro merged commit f785fc5 into DependencyTrack:master Jun 2, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Event: Bom Validation Failed
2 participants