-
-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Notification For BOM_VALIDATION_FAILED
#3796
Add Notification For BOM_VALIDATION_FAILED
#3796
Conversation
If uploaded BOM is invalid, dispatches a notification with InvalidBomProblemDetails before throwing the respective exception Signed-off-by: Aravind Parappil <[email protected]>
Signed-off-by: Aravind Parappil <[email protected]>
Signed-off-by: Aravind Parappil <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more |
src/main/java/org/dependencytrack/notification/vo/BomValidationFailed.java
Outdated
Show resolved
Hide resolved
Instead of adding the whole problemDetails object, just storing the errors now Signed-off-by: Aravind Parappil <[email protected]>
Signed-off-by: Aravind Parappil <[email protected]>
Signed-off-by: Aravind Parappil <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
On a related note, any thoughts on #3795?
Description
If uploaded BOM is invalid, dispatches a notification with InvalidBomProblemDetails before throwing the respective exception
Addressed Issue
Fixes #3778 (Dependent on frontend PR)
Additional Details
In the existing
BomResource.validate()
method, added functionality to dispatch aNotification
forBOM_VALIDATION_FAILED
Checklist