Make based-connect work with QC35 Series 2 and new firmware #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make it work with new firmware by changing the mask * Add new languages to get / set for voice prompts
* No idea what previous BT command did / why it was there. * The last check failed so it didn't proceed to status printing, without it works, so remove it ;)
This was referenced May 13, 2021
|
Hi, I applied your changes in a new repository that I created based on this. The idea is to have an active community to improve this genius idea. You are welcome to visit the new repository. |
|
Tested this PR with firmware 2.0.1, works! |
zaddach
added a commit
to zaddach/based-connect
that referenced
this pull request
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with firmware 4.8.1 and QC35 Series 2:
No idea if this also works on older firmware / devices.