New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up computation of glacier parameters #141

Open

hboisgon opened this issue Jan 10, 2023 · 1 comment

Labels

Contributor

hboisgon commented Jan 10, 2023

Seems we compute glacier store and frac by looping over glacier. We may be able to do this faster by computing for all glaciers at once:

hydromt_wflow/hydromt_wflow/workflows/glaciers.py

Lines 94 to 97 in 04fad11

    
           for i in range(len(gdf)): 
        
               glacier = gdf.iloc[i] 
        
               gridded_glacier = gdf_grid.intersection(glacier.geometry) 
        
               gridded_glacier = gridded_glacier.loc[~gridded_glacier.is_empty]

hboisgon added the enhancement label

Contributor Author

hboisgon commented Dec 14, 2023

Closed as duplicate of #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment