Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for geopandas>=1.0 #135

Open
2 tasks done
veenstrajelmer opened this issue Sep 20, 2024 · 0 comments
Open
2 tasks done

Support for geopandas>=1.0 #135

veenstrajelmer opened this issue Sep 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 20, 2024 •
edited
Loading

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Reproducible Example

hydromt_delft3dfm testcases

Current behaviour

When running the testbank with geopandas>=1.0.0, two testcases fail:

FAILED tests/test_hydromt.py::test_model_build[piave] - ValueError: cannot insert branchid, already exists
FAILED tests/test_hydromt.py::test_model_build[local] - ValueError: cannot insert branchid, already exists

Desired behaviour

Successful tests, also with updated geopandas

Additional context

This might be related to geopandas futurewarning in #103
@veenstrajelmer veenstrajelmer added the bug Something isn't working label Sep 20, 2024
@veenstrajelmer veenstrajelmer mentioned this issue Sep 20, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@veenstrajelmer