Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas TimeDelta formatting changed #134

Closed
2 tasks done
shartgring opened this issue Aug 6, 2024 · 1 comment
Closed
2 tasks done

pandas TimeDelta formatting changed #134

shartgring opened this issue Aug 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@shartgring
Copy link
Collaborator

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Reproducible Example

See also: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Timedelta.html

Deprecated since version 2.2.0: Values H, T, S, L, U, and N are deprecated in favour of the values h, min, s, ms, us, and ns.

Current behaviour

The code uses _TIMESTR = {"D": "days", "H": "hours", "T": "minutes", "S": "seconds"}

Desired behaviour

Update _TIMESTR, maybe with additional check to support older pandas versions?

Additional context

No response

@shartgring shartgring added the bug Something isn't working label Aug 6, 2024
@shartgring
Copy link
Collaborator Author

Is fixed after #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant