Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed test due to dependency updates #128

Open
2 tasks done
xldeltares opened this issue Mar 15, 2024 · 1 comment
Open
2 tasks done

failed test due to dependency updates #128

xldeltares opened this issue Mar 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@xldeltares
Copy link
Collaborator

Version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version.

Reproducible Example

Running the current tests gives error.

Current behaviour

Error from xugrid
Grids share dimension names but do not are not identical. Matching dimensions: {'network1d_nEdges', 'network1d_nNodes'}
Errors from hydromt-delft3dfm

Desired behaviour

no errors

Additional context

No response

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 10, 2024

When reverting a xugrid change, the hydromt_delft3dfm code works again. This is documented in this xugrid PR: Deltares/xugrid#220. However, this is not a desireable change for xugrid, so we should find a better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants