Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unittest for spherical networks #119

Open
veenstrajelmer opened this issue Dec 5, 2023 · 0 comments
Open

Add unittest for spherical networks #119

veenstrajelmer opened this issue Dec 5, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Dec 5, 2023

Kind of request

Adding new functionality

Enhancement Description

The current code mostly assumes cartesian/projected networks. There is a lot of conversion done between meshkernel objects, hydrolib-core network objects, xugrid object and netcdf files. This will probably go fine for cartesian, but for spherical/geographic networks there are a lot of things that can fail. Including whether interacter/FM reads the resulting network as spherical (via the epsg/grid_mapping attributes.

Additional checks are relevant for both spherical and cartesian:

  • check if the crs is maintained throughout the process
  • check if bathy is maintained/updated throughout the process (including mesh refinement)

Use case

Additional Context

@veenstrajelmer veenstrajelmer added the enhancement New feature or request label Dec 5, 2023
@veenstrajelmer veenstrajelmer self-assigned this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant