Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for build_2dmodel.ipynb #107

Open
1 task done
veenstrajelmer opened this issue Oct 25, 2023 · 0 comments
Open
1 task done

Suggestions for build_2dmodel.ipynb #107

veenstrajelmer opened this issue Oct 25, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 25, 2023

Version checks

  • I have checked that the issue still exists on the latest versions

Kind of issue

Docs are unclear

Documentation problem

Data for model setup:

  • <...>_fn was not introduced before, not sure what thisis about yet. This probably links to the yml file?
  • typos: "additionnal", "default parameters values" (suggestion: "default model parameters"), "paramter"

Model setup configuration:

  • "The supported format are either YAML or INI" >> since hydromt_delft3dfm is new and I think INI will be deprecated, maybe just pretend it is always yaml?
  • crs is EPSG:3857 (pseudo mercator), why not EPSG:4326 (mercator)? >> spherical seems not supported
@veenstrajelmer veenstrajelmer added the documentation Improvements or additions to documentation label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant