Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Effects of adding dfm_tools as requirement #106

Open
veenstrajelmer opened this issue Oct 25, 2023 · 0 comments
Open

Effects of adding dfm_tools as requirement #106

veenstrajelmer opened this issue Oct 25, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Oct 25, 2023

Kind of request

Adding new functionality

Enhancement Description

In the process of moving 2D3D features from dfm_tools to hydromt_delft3dfm, we want to avoid maintaining functions in two repositories. Also, the current modelbuilder has to keep functioning untill all features are available in hydromt_delft3dfm, so we will have a transition period. In the meantime, we could consider adding dfm_tools as dependency to hydromt_delft3dfm.

This issue documents the dfm_tools dependencies that are no core dependencies of hydromt/hydromt_delft3dfm, and would thus be additionally installed when adding dfm_tools as dependency:

  • matplotlib: hydromt[extra]
  • contextily
  • cdsapi
  • pydap
  • copernicusmarine

Use case

No response

Additional Context

No response

@veenstrajelmer veenstrajelmer added the enhancement New feature or request label Oct 25, 2023
@veenstrajelmer veenstrajelmer self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant