Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality #57

Open
veenstrajelmer opened this issue Dec 15, 2022 · 0 comments
Open

Improve code quality #57

veenstrajelmer opened this issue Dec 15, 2022 · 0 comments

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Dec 15, 2022

Todo:

  • convert TODO from hatyan functions and example scripts into Github issues (https://github.com/search?q=repo%3ADeltares%2Fhatyan+TODO&type=code, 55 occurences on 15-12-2022, 14 on 13-5-2024)
  • reduce code complexity of analysis_prediction.py and timeseries.py
  • clean up code with help of SIG, status badge shows quality status or only finishing of action? Possible to let badge link to public online dashboard with code analysis results? Possible to let badge show color-coded code rating? Possible to (also) get all-code scores back from analysis (now only new code and often N/A)
  • improve code quality by solving sonarcloud high severity issues (21 issues at 6-9-2024)
  • style guide: https://www.python.org/dev/peps/pep-0008/
  • isort/black
  • argument type checking (pydantic?) >> hatyansettings
  • introduce types for essential variables: https://docs.python.org/3/library/typing.html (and update docstring)
  • Check flake8 warnings, maybe i.c.w. black code formatter
@veenstrajelmer veenstrajelmer changed the title Github improvements Improve code quality May 13, 2024
@veenstrajelmer veenstrajelmer mentioned this issue May 13, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant