New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove escape for single partition #958

Closed

1 of 4 tasks

veenstrajelmer opened this issue Aug 15, 2024 · 1 comment

Collaborator

veenstrajelmer commented Aug 15, 2024 •

edited

Loading

Since this case is now caught in xugrid after Deltares/xugrid#280, we can safely remove the following:

dfm_tools/dfm_tools/xugrid_helpers.py

Lines 245 to 246 in 62d6db4

    
           if len(partitions) == 1: #do not merge in case of 1 partition 
        
               return partitions[0]

Todo:

fix caught empty list of partitions in xu.merge_partitions() xugrid#280
wait for new xugrid release
set new minimal version in pyproject.toml
remove this escape from the code, we will still get the merging timing in this case, so maybe keep the escape?

veenstrajelmer mentioned this issue

Prepare 0.25.0 release #907

Closed

27 tasks

Collaborator Author

veenstrajelmer commented Aug 15, 2024

Better to keep the escape to avoid confusion timings and potential other messages.

veenstrajelmer closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment