-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gridedit 1360 improve clg generation from spline #363
Merged
BillSenior
merged 28 commits into
master
from
feature/GRIDEDIT-1360_improve_clg_generation_from_spline
Oct 28, 2024
Merged
Feature/gridedit 1360 improve clg generation from spline #363
BillSenior
merged 28 commits into
master
from
feature/GRIDEDIT-1360_improve_clg_generation_from_spline
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillSenior
force-pushed
the
feature/GRIDEDIT-1360_improve_clg_generation_from_spline
branch
from
October 14, 2024 09:56
94bc6ff
to
0c85bb0
Compare
BillSenior
force-pushed
the
feature/GRIDEDIT-1360_improve_clg_generation_from_spline
branch
from
October 22, 2024 07:35
e597954
to
3e18ada
Compare
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
libs/MeshKernel/src/CurvilinearGrid/CurvilinearGridFromSplines.cpp
Outdated
Show resolved
Hide resolved
lucacarniato
approved these changes
Oct 24, 2024
Removed unnecessary and unused code
Also removed unnecessary cout
Fixed several sonar cloud warnings
This became unnecessary when the code was simplified
BillSenior
force-pushed
the
feature/GRIDEDIT-1360_improve_clg_generation_from_spline
branch
from
October 28, 2024 11:34
33222df
to
a6dd3ac
Compare
BillSenior
deleted the
feature/GRIDEDIT-1360_improve_clg_generation_from_spline
branch
October 28, 2024 12:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.