Feature/gridedit 589 query sys mem bench #196
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…| GRIDEDIT-586 )
…arameters (#180 | GRIDEDIT-563 )
…DEDIT-589_query_sys_mem_bench
…DEDIT-589_query_sys_mem_bench
…9_query_sys_mem_bench
lucacarniato
requested changes
Jul 13, 2023
| MemoryMonitor() = default; | ||
| virtual ~MemoryMonitor() = default; | ||
| // non-copyable | ||
| MemoryMonitor(const MemoryMonitor& other) = delete; |
There was a problem hiding this comment.
you might move all deleted constructors and operators to private
| // PROCESS_MEMORY_COUNTERS_EX pmc; | ||
| PROCESS_MEMORY_COUNTERS pmc; | ||
| if (GetProcessMemoryInfo(m_current_process, | ||
| reinterpret_cast<PPROCESS_MEMORY_COUNTERS>(&pmc), |
There was a problem hiding this comment.
reinterpret_cast<PPROCESS_MEMORY_COUNTERS> might not be needed
| switch (memory_type) | ||
| { | ||
| case MemoryType::Physical: | ||
| return static_cast<uint64_t>(pmc.WorkingSetSize); |
There was a problem hiding this comment.
also all these static casts
| void Start() override; | ||
|
|
||
| /// @brief Stop recording and fills out the given Result structure | ||
| /// @param[result] Structure |
| ~WindowsMemoryMonitor() = default; | ||
|
|
||
| // non-copyable | ||
| WindowsMemoryMonitor(const WindowsMemoryMonitor&) = delete; |
| std::string Statistics(std::string const& caller = std::string()) const; | ||
|
|
||
| /// @brief Overlaod of oepartor << for printing the statistics of the class MemorySystemQuery | ||
| /// @param[ostream] Output stream |
There was a problem hiding this comment.
| int64_t m_max_bytes_used = TombstoneValue; ///< The peak memory use in bytes between Start and Stop | ||
|
|
||
| MemorySystemQuery() = default; | ||
| ~MemorySystemQuery() = default; |
There was a problem hiding this comment.
~MemorySystemQuery() override = default;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.