You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code quality, test coverage and user friendliness was improved in 0.2.0 and the output format was improved in 0.3.0. Several steps are required for the results to be official (e.g. updates in measurement data and automatic retrieval of HYDRA statistics). These dependencies might only be resolved in 2025.
check size of resulting netcdf files with engine='h5netcdf' (which is often used after fixing 125 add windows tests Deltares/ddlpy#126) >> nothing changed in kw env, so no changes expected
consider enforcing nyears in kw.crop_timeseries_last_nyears() instead of warning, requires quite some updates to gemiddelgetij and havengetallen tests and a df_ext_12 (of 10y)
publish to database instead of csv's? Makes it possible to add metadata like unit, station x/y/code/name, vertref, kenmerkendewaarden-package-version etc. Temporarily add to Deltares database, or wait for RWS database to be consolidated?
Reporting:
rapportage evt met Quarto: iets online via bookdown R of opvolger, een webpage of pdf. Mooie methode voor technische rapporten, kan ook met Deltares LaTeX template: https://www.testsysteemrapportage.nl/wadden/_main.pdf Of gewoon sphinx docs op github?
docstrings do/will contain the technical user information about input/output of functions and what they do
the description of the kenmerkende waarden can be in sphinx documentation (what does it represent, why this method, interaction)
additionally a pdf report with description of historic methods and motivation of improvements/simplification? Maybe including comparison of methods if still reproducible This information is not all relevant for the online documentation, since not all users will be interested in this. But it is good to document motivation for changes somewhere.
which language where?
the RWS dashboard will show the results for all stations, so here we can focus on one example station (or some)
also document which output (csv files, figures, boi timeseries) is relevant for which process (including contact person)
Products:
github toolbox
final results
report?
The text was updated successfully, but these errors were encountered:
The code quality, test coverage and user friendliness was improved in 0.2.0 and the output format was improved in 0.3.0. Several steps are required for the results to be official (e.g. updates in measurement data and automatic retrieval of HYDRA statistics). These dependencies might only be resolved in 2025.
Todo:
compute_expected_counts
gives incorrect values for HANSWT ext #88physical_break_dict
#150calc_havengetallen
#164calc_gemiddeldgetij
#169engine='h5netcdf'
(which is often used after fixing 125 add windows tests Deltares/ddlpy#126) >> nothing changed in kw env, so no changes expectednyears
inkw.crop_timeseries_last_nyears()
instead of warning, requires quite some updates to gemiddelgetij and havengetallen tests and adf_ext_12
(of 10y)Later (2025):
Todo not related to methods:
.pre_commit_config.yml
?Reporting:
Products:
The text was updated successfully, but these errors were encountered: