Fails to compile on solus.

[ninao-xyz]

Hello, I tried to compile this on solus-budgie which is currently using gnome3.26.2, but it fails with some warnings about deprecated functions.

You probably don't have much time to fix those issues, although I think I should report the issue anyway. I'm also an artist so I don't know how to fix this.

17:10:48 ninao@soul ▶ make
  CC       gnome_openraster_thumbnailer-gnome-openraster-thumbnailer.o
  CC       gnome_openraster_thumbnailer-gnome-thumbnailer-skeleton.o
gnome-thumbnailer-skeleton.c: In function ‘main’:
gnome-thumbnailer-skeleton.c:60:2: warning: ‘g_type_init’ is deprecated [-Wdeprecated-declarations]
  g_type_init ();
  ^~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from gnome-thumbnailer-skeleton.c:24:
/usr/include/glib-2.0/gobject/gtype.h:686:23: note: declared here
 void                  g_type_init                    (void);
                       ^~~~~~~~~~~
  CCLD     gnome-openraster-thumbnailer
  CC       gnome_kra_thumbnailer-gnome-kra-thumbnailer.o
  CC       gnome_kra_thumbnailer-gnome-thumbnailer-skeleton.o
gnome-thumbnailer-skeleton.c: In function ‘main’:
gnome-thumbnailer-skeleton.c:60:2: warning: ‘g_type_init’ is deprecated [-Wdeprecated-declarations]
  g_type_init ();
  ^~~~~~~~~~~
In file included from /usr/include/glib-2.0/gobject/gobject.h:24:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from /usr/include/glib-2.0/gio/gioenums.h:28,
                 from /usr/include/glib-2.0/gio/giotypes.h:28,
                 from /usr/include/glib-2.0/gio/gio.h:26,
                 from gnome-thumbnailer-skeleton.c:24:
/usr/include/glib-2.0/gobject/gtype.h:686:23: note: declared here
 void                  g_type_init                    (void);
                       ^~~~~~~~~~~
  CCLD     gnome-kra-thumbnailer
  GEN      gnome-openraster-thumbnailer.thumbnailer
  GEN      gnome-kra-thumbnailer.thumbnailer

[Deevad]

Hey @ni-code ; thank you for the report!
Here on Ubuntu 17.10 I still use the *.deb ( in the release tab ); and I know Fedora is the only distro packaging it ( a AUR repo exist for Arch ) and never tested recompiling since a long time. The code base of this project became too complex for me after the rewrite from @hadess so I have no idea how to fix this build issue.

@hadess if you are around, can you look at it? Thank you!

[hadess]

Hello, I tried to compile this on solus-budgie which is currently using gnome3.26.2, but it fails with some warnings about deprecated functions.

Warnings aren't errors. Looks like it compiled ok as well.

Here on Ubuntu 17.10 I still use the *.deb ( in the release tab ); and I know Fedora is the only distro packaging it ( a AUR repo exist for Arch ) and never tested recompiling since a long time.

This is the upstream I work on is at:
https://git.gnome.org/browse/gnome-kra-ora-thumbnailer/

[ninao-xyz]

@hadess Indeed, warnings are not errors, my bad sorry.
I've tried again with the repo you link from gnome, it compiles with the same warnings and installs fine then I rebooted just to make sure, but the thumbnails aren't generated.

I also gave a try by extracting the files from the .deb and copy/pasting them manually, and again the thumbnails aren't generated.

So, it's probably a solus thing... by the way I've used this on ubuntu before, I know it works fine in there. It's not a big deal if I can't make it work on solus.

@Deevad @hadess Tks for your time. Shall I close the issue?

[hadess]

I think it might be best to ask Solus how you're supposed to compile the thumbnailer for it to be registered by the system. I don't know which libraries Solus uses, and what paths it expects.

[Deevad]

Thank you @hadess for continuing the project in GNOME directly ; I'll archive this repo on Github and redirect in README to the address you mentioned here.